Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig-storage chairs #352

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Add sig-storage chairs #352

merged 1 commit into from
Nov 19, 2024

Conversation

alicefr
Copy link
Member

@alicefr alicefr commented Nov 18, 2024

What this PR does / why we need it:
Add contacts and meetings details for sig-storage

Release note:

Add sig-storage chairs and meeting details

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 18, 2024
@alicefr
Copy link
Member Author

alicefr commented Nov 18, 2024

/cc @mhenriks

@alicefr
Copy link
Member Author

alicefr commented Nov 18, 2024

I did something wrong with the make generate, let me fix it, sorry

@alicefr
Copy link
Member Author

alicefr commented Nov 18, 2024

Fixed

@mhenriks
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
sig-list.md Outdated
@@ -32,7 +32,7 @@ Each group's material is in its subdirectory in this project.
|------|-----------|------------|---------|----------|
|[sig-compute](sig-compute/charter.md) |[sig/compute](https://github.com/kubevirt/kubevirt/labels/sig/compute) | <ol><li>[Itamar Holder](https://github.com/iholder101), Red Hat</li><li>[Jed Lejosne](https://github.com/jean-edouard), Red Hat</li></ol> |[Slack](kubevirt-dev)<br/> [Mailing List](https://groups.google.com/forum/#!forum/kubevirt-dev) |<ul></ul> |
|[documentation](sig-documentation/charter.md) |[sig/documentation](https://github.com/kubevirt/kubevirt/labels/sig/documentation) | | |<ul></ul> |
|[storage](sig-storage/charter.md) |[sig/storage](https://github.com/kubevirt/kubevirt/labels/sig/storage) | | |<ul></ul> |
|[storage](sig-storage/charter.md) |[sig/storage](https://github.com/kubevirt/kubevirt/labels/sig/storage) | <ol><li>[Alice Frosi](https://github.com/alicefr), Red Hat</li><li>[Michael Henriksen](https://github.com/mhenriks), Red Hat</li></ol> | |<ul><li>KubeVirt Storage SIG Meeting: [ Thursday at 1:00 PM UTC (bimonthly) ](https://zoom.us/j/97050528531)</li></ul> |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the meetings on Mondays?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aburdenthehand does it have to be? I'm just happy that these meetings are taking place now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they are Mondays

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry wrong copy paste

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alicefr !

sigs.yaml Outdated
company: Red Hat
meetings:
- description: KubeVirt Storage SIG Meeting
day: Thursday
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still Thursday, where it should be Monday: https://calendar.google.com/calendar/u/0/[email protected]

Signed-off-by: Alice Frosi <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
@alicefr
Copy link
Member Author

alicefr commented Nov 19, 2024

@dhiller now it should be fixed

@aburdenthehand
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
@vladikr
Copy link
Member

vladikr commented Nov 19, 2024

/approve

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@kubevirt-bot kubevirt-bot merged commit 3c7a366 into kubevirt:main Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants